Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated s3_website module #41

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

zachreborn
Copy link
Owner

@zachreborn zachreborn commented Jan 4, 2024

Description

Fixes #40

The s3_website module has been deprecated since v2.14.0. This removes the deprecated module which is no longer being maintained nor utilizes modern best practices.

If you must keep utilizing this module, you will need to stay on v2.15.0 or older for terraform-modules.

Migration Path

Move the state of any modules utilizing s3_website to the s3/bucket module using a moved block. See the following hashicorp documentation for information on how to perform this - https://developer.hashicorp.com/terraform/language/modules/develop/refactoring

Match up the resources and components from the s3_website module to the s3/bucket module
s3_website - https://github.com/zachreborn/terraform-modules/tree/v2.15.0/modules/aws/s3/s3_website
bucket - https://github.com/zachreborn/terraform-modules/tree/main/modules/aws/s3/bucket

An example of a S3 website utilizing the s3/bucket module:

module "example_org_website_bucket" {
  source                     = "github.com/zachreborn/terraform-modules//modules/aws/s3/bucket"
  bucket                     = "example.org"
  enable_website             = true
  tags = {
    created_by  = "<YOUR_NAME>"
    environment = "prod"
    terraform   = "true"
  }
}

@zachreborn zachreborn merged commit f2e60ff into main Jan 4, 2024
6 checks passed
@zachreborn zachreborn deleted the remove_deprecated_s3_website_module branch January 4, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - S3 Access block should restrict public bucket to limit access
1 participant