Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect ReadMode for HabraHabr.ru #25

Closed
lutc opened this issue Dec 6, 2016 · 4 comments
Closed

incorrect ReadMode for HabraHabr.ru #25

lutc opened this issue Dec 6, 2016 · 4 comments

Comments

@lutc
Copy link

lutc commented Dec 6, 2016

No description provided.

@ZachSaucier ZachSaucier added the bug label Dec 6, 2016
@ZachSaucier
Copy link
Owner

Particular articles on HabraHabr.ru seem to work just fine, such as this example. Can you please link to a more specific page that doesn't work for you?

@lutc
Copy link
Author

lutc commented Dec 6, 2016

https://habrahabr.ru/post/310438/
You're right. I tried only this page and closed habr with sad face. Other articles works good

@ZachSaucier
Copy link
Owner

Thanks for providing the direct link!

I've just thought of a way that I think I can avoid problems like this, but I don't have time to implement the change right now. I'll update this post when I have had time to implement the change.

Until then, you can use Just Read's user selection mode or highlight mode to select article content like that where the auto-selection doesn't work. Read more about them on the docs page

@ZachSaucier
Copy link
Owner

I added a class "blacklist" in 1.0.14 that Just Read now checks for when auto-selecting elements. In essence, it checks potential selection's className for the substring in the blacklist.

Currently it only has "comment" in the blacklist. As I come across others I will add them.

As such, it now selects a more-correct container for the page you linked (though it's still not perfect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants