Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet/Explorer improvements #173

Closed
ghost opened this issue Jul 23, 2018 · 8 comments
Closed

Wallet/Explorer improvements #173

ghost opened this issue Jul 23, 2018 · 8 comments

Comments

@ghost
Copy link

ghost commented Jul 23, 2018

1. Link light node wallet.html to explorer.html on same node, and vice versa.

2. On mainstream wallets SEND is SEND NOW:
Solution: Spend or Send on most wallets "signs and broadcasts" the transaction, and should be default behaviour. The other option ("unsigned spend") is the less commonly used feature, and should be the more descriptive one. E.g. "generate transaction, but do not sign or send". This will reduce confusion.

3. Copying and pasting recipient address with trailing space or period is a common problem:
When a sending a tx, the "to pubkey:" field should automatically parse for spaces and newline characters (or any other common noise, such as . at the end of the address due to workerID. It should parse for the B and = characters and/or length for the beginning and end of the address.

4. Maximum amount is a common feature on modern wallets:
There should be a "maximum amount" button. This is similar to the "send all your veo to this address" button, but in a safer, more common implementation. Requires: pubkey field to be filled because maximum amount depends on fee, which depends on new/existing account.

  • if pubkey field is not filled, display message, "please input recipient address."
  • "send" button must still be pressed to complete the transaction, the "maximum amount" button merely populates the "amount to send" field.

5. When sending a tx fails, there should be detailed feedback as to why it has failed:

  • You do not have this much veo. Your balance is: x
  • Load your keys and check your balance first
  • You do not have enough veo to cover the fee, use the maximum amount button to populate the amount field
  • This is not a valid recipient address
  • or whatever is the appropriate reason, in a low level and user oriented language

6. When a send succeeds, this should be detailed as well:

  • Your tx [hash] for x Veo has been sent to B...= and is in the txpool. Your balance after transaction. Their balance after transaction. [Button to see if tx was included in a block or is still in txpool]. z confirmations.

7. Steps should be taken to reduce clutter on light wallet:
Accordion style elements defaulting to only wallet features visible would go a long way for new users not feeling overwhelmed in a cluttered utilitarian interface. They can explore/expand other features once they are comfortable with the wallet. None of the other features are worthwhile if they cannot save/load keys and send veo.

This is based on my experience helping people 1 on 1 with simple transactions and trades. Please discuss.

@ghost
Copy link
Author

ghost commented Jul 23, 2018

Other ideas:
8. Can node "know" if it's on an old fork and report that it is not topheight?

9. Display balance immediately upon loading keys.

@zack-bitcoin
Copy link
Owner

These are all great ideas.

  1. yes we can do that.

@zack-bitcoin
Copy link
Owner

suggestion (1) completed. 271d020

@zack-bitcoin
Copy link
Owner

suggestion (2) completed. 2efdb1c

@zack-bitcoin
Copy link
Owner

suggestion (3) completed. 754f4dd

@zack-bitcoin
Copy link
Owner

suggestion (4) completed. ef55693

@zack-bitcoin
Copy link
Owner

suggestion (9) complete. e3ffc3e

@zack-bitcoin
Copy link
Owner

suggestion (4) wasn't working before. now it is a71a5dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant