Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set window title and icon #5

Closed
zacps opened this issue Feb 28, 2018 · 4 comments
Closed

Set window title and icon #5

zacps opened this issue Feb 28, 2018 · 4 comments
Assignees
@zacps
Labels
blocked help wanted

Comments

@zacps
Copy link
Owner

zacps commented Feb 28, 2018 •
edited

Window title is blank for some reason.
The title should be set in src/window.rs#186.
Also set the executable icon to the one from jwilm/alacritty#285 possibly using winres.
@zacps zacps mentioned this issue Mar 2, 2018
Merged
zacps pushed a commit that referenced this issue Mar 2, 2018
@dparnell @zacps
Windows EXE icon - issue #5 (#13)
f089ae8 
* Added an ICO resource to the Windows EXE
@zacps
Copy link
Owner Author

zacps commented Mar 2, 2018

#13 added the windows icon to the application manifest.
However the icon (and title) do not display on the window title bar.
Waiting on rust-windowing/winit#69 for icon support.

@zacps
Copy link
Owner Author

zacps commented Mar 3, 2018

With the merge of #15 the dynamic part of the title (The running process) displays correctly but the initial title of 'Alacritty' does not.

@zacps
Copy link
Owner Author

zacps commented Jun 11, 2018

Now that rust-windowing/winit/pull/497 has been merged it should be possible to get the window icon fixed.

@zacps zacps self-assigned this Jun 11, 2018
@zacps
Copy link
Owner Author

zacps commented Jun 16, 2018

Potentially blocked on image-rs/image#780

@zacps zacps added the blocked label Jun 17, 2018
@zacps zacps closed this as completed Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zacps zacps

Labels
blocked help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zacps