fix orderby with multiple labels, closes #4220

zadam · Sep 5, 2023 · 7b662b0 · 7b662b0
1 parent f8e4a66
commit 7b662b0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/spec/search/lexer.spec.js b/spec/search/lexer.spec.js
@@ -4,6 +4,9 @@ describe("Lexer fulltext", () => {
     it("simple lexing", () => {
         expect(lex("hello world").fulltextTokens.map(t => t.token))
             .toEqual(["hello", "world"]);
+
+        expect(lex("hello, world").fulltextTokens.map(t => t.token))
+            .toEqual(["hello", "world"]);
     });
 
     it("use quotes to keep words together", () => {
@@ -147,6 +150,11 @@ describe("Lexer expression", () => {
         expect(lex(`# not(#capital) and note.noteId != "root"`).expressionTokens.map(t => t.token))
             .toEqual(["#", "not", "(", "#capital", ")", "and", "note", ".", "noteid", "!=", "root"]);
     });
+
+    it("order by multiple labels", () => {
+        expect(lex(`# orderby #a,#b`).expressionTokens.map(t => t.token))
+            .toEqual(["#", "orderby", "#a", ",", "#b"]);
+    });
 });
 
 describe("Lexer invalid queries and edge cases", () => {

diff --git a/src/services/search/services/lex.js b/src/services/search/services/lex.js
@@ -11,7 +11,7 @@ function lex(str) {
     let currentWord = '';
 
     function isSymbolAnOperator(chr) {
-        return ['=', '*', '>', '<', '!', "-", "+", '%'].includes(chr);
+        return ['=', '*', '>', '<', '!', "-", "+", '%', ','].includes(chr);
     }
 
     function isPreviousSymbolAnOperator() {
@@ -128,6 +128,10 @@ function lex(str) {
             }
         }
 
+        if (chr === ',') {
+            continue;
+        }
+
         currentWord += chr;
     }