Skip to content

Commit

Permalink
fix click events propagating from context menu being closed, fixes #3805
Browse files Browse the repository at this point in the history
  • Loading branch information
zadam committed Apr 6, 2023
1 parent 517f199 commit e871edc
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/public/app/menus/context_menu.js
Expand Up @@ -147,7 +147,9 @@ class ContextMenu {
// "contextmenu" event also triggers "click" event which depending on the timing can close just opened context menu
// we might filter out right clicks, but then it's better if even right clicks close the context menu
if (Date.now() - this.dateContextMenuOpenedMs > 300) {
this.$widget.hide();
// seems like if we hide the menu immediately, some clicks can get propagated to the underlying component
// see https://github.com/zadam/trilium/pull/3805 for details
setTimeout(() => this.$widget.hide(), 100);
}
}
}
Expand Down

0 comments on commit e871edc

Please sign in to comment.