Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Notes not editable after script execution #3483

Closed
Nriver opened this issue Jan 4, 2023 · 4 comments
Closed

(Bug report) Notes not editable after script execution #3483

Nriver opened this issue Jan 4, 2023 · 4 comments

Comments

@Nriver
Copy link
Contributor

Nriver commented Jan 4, 2023

Trilium Version

v0.58.2-beta

What operating system are you using?

Windows

What is your setup?

Local (no sync)

Operating System Version

Window 10

Description

  1. Create a JS frontend note with the following content.
alert("111");

execute it, and close the popup window.

  1. None of the notes is editable now.

It may have something todo with the focus. As I hit alt+tab twice, the note will go back to normal.

The issue only occurs in client, the browser is fine.

Error logs

No response

@zadam
Copy link
Owner

zadam commented Jan 4, 2023

Hi, IIRC this is an electron bug, e.g. described here: electron/electron#19977

The workaround is to not use alert(), confirm(), prompt().

@Nriver
Copy link
Contributor Author

Nriver commented Jan 5, 2023

In that case, we should change the code example for script launcher.

zadam added a commit that referenced this issue Jan 5, 2023
@zadam
Copy link
Owner

zadam commented Jan 5, 2023

True, fixed.

@Nriver
Copy link
Contributor Author

Nriver commented Jan 9, 2024

Close as fixed.

@Nriver Nriver closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants