Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Bookmarks not working on 0.58.4 #3514

Closed
Lightirius opened this issue Jan 12, 2023 · 5 comments
Closed

(Bug report) Bookmarks not working on 0.58.4 #3514

Lightirius opened this issue Jan 12, 2023 · 5 comments

Comments

@Lightirius
Copy link

Lightirius commented Jan 12, 2023

Trilium Version

0.58.4

What operating system are you using?

Windows

What is your setup?

Local + server sync

Operating System Version

Windows 11 Pro 21H2

Description

After update to 0.58.4 from 0.57.5 notes with BookmarkFolder and bookmarked attributes are no longer displayed in the launchbar
I have Bookmarks launcher in the visible launchers sub-tree in new launchbar configuration

Error logs

No response

@zadam
Copy link
Owner

zadam commented Jan 12, 2023

Hello, in 0.58 the bookmark implementation changed and it doesn't use #bookmarked label anymore. However, all such labels/bookmarks should have been migrated to the new (clone based) implementation.

Did this migration not work for you? Or do you perhaps assign the #bookmarked label manually or via script?

@Lightirius
Copy link
Author

Migrations didn't work. I had a few notes with manually added #BookmarkFolder labels, but they are missing frome the launchbar after update.
Tested it again with portable Trilium and demo database - #bookmarked migrates fine, but #BookmarkFolder folders disappears from the launchbar after update.

Also, what is the new way to create bookmarks? New launcher is empty and wiki page about them is outdated
image

@Lightirius
Copy link
Author

Lightirius commented Jan 12, 2023

Disregard the question about how to create bookmarks. I somehow always missed the Bookmark toggle on the basic properties

@Lightirius
Copy link
Author

Found the problem - on the 0.57.5 #bookmarkFolder label was working fine without #bookmarked label.
It looks like migrations don't check that case

@zadam
Copy link
Owner

zadam commented Jan 13, 2023

Found the problem - on the 0.57.5 #bookmarkFolder label was working fine without #bookmarked label.

That's right - I did not realize it was possible to have a folder without the #bookmarked label. Migration has been fixed now. Sorry for the trouble.

@zadam zadam closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants