Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Table of Contents (ToC) is uncloseable in split note view #4093

Closed
perfectra1n opened this issue Jul 13, 2023 · 5 comments
Closed

Comments

@perfectra1n
Copy link

perfectra1n commented Jul 13, 2023

Trilium Version

0.60.4

What operating system are you using?

Windows

What is your setup?

Local + server sync

Operating System Version

Windows 10

Description

The Table of Contents becomes uncloseable when using the split pane functionality:
trilium_ePhqQMhKg9

The highlighting and unhighlighting of the x isn't me clicking, that's the frontend constantly stuck in some weird case 👀

No matter how fiendishly I click, I can't close the ToC lol. If there's anything more I can help with, please let me know. Obviously something weird is going on in toc-widget...

The aria-describedby value is changing over and over again when it's highlighted...
image

Error logs

No response

@XXXJetfireXXX
Copy link

XXXJetfireXXX commented Jul 14, 2023

Hmm, I wasn't able to reproduce the bug, it works fine with splits on my side: when I open two notes in split mode, both have TOC; then, I can close it for each split individually. Do you have #toc label in the second note or did you change this setting?
image
I have the same version on the same OS, but without sync server.

@perfectra1n
Copy link
Author

perfectra1n commented Jul 14, 2023

Hmmm, that's interesting, I have it set to -1 so that it always shows...could be part of the issue lol
image

I've swapped it to 1, and it still has the same issue on my MacOS...
image

@XXXJetfireXXX
Copy link

MacOS? I thought you were using the version for Windows, as it is defined in the issue.

@perfectra1n
Copy link
Author

Yes I was just mentioning that the issue is happening on my MacOS as well :)

@zadam
Copy link
Owner

zadam commented Jul 15, 2023

Hi, I managed to reproduce it and fix it in 0.61 branch. It seems to be some visual/placement glitch.

Thanks for reporting.

@zadam zadam closed this as completed Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants