fix: disable left click when context menu opening

src/public/app/menus/context_menu.js

@@ -5,6 +5,8 @@ class ContextMenu {
         this.$widget = $("#context-menu-container");
         this.dateContextMenuOpenedMs = 0;
 
+        this.hideHandlers = [];
+
         $(document).on('click', () => this.hide());
     }
 
@@ -20,6 +22,8 @@ class ContextMenu {
         this.positionMenu();
 
         this.dateContextMenuOpenedMs = Date.now();
+
+        return this;
     }
 
     positionMenu() {
@@ -148,8 +152,22 @@ class ContextMenu {
         // we might filter out right clicks, but then it's better if even right clicks close the context menu
         if (Date.now() - this.dateContextMenuOpenedMs > 300) {
             this.$widget.hide();
+
+            setTimeout(() => {
+                this.hideHandlers.forEach(fn => {
+                    fn(this);
+                });
+            }, 0);
+
         }
     }
+    onHide(fn) {
+        this.hideHandlers.push(fn);
+        return () => {
+            const fnIndex = this.hideHandlers.findIndex(v => v === fn);
+            this.hideHandlers.splice(fnIndex, 1);
+        };
+    }
 }
 
 const contextMenu = new ContextMenu();

src/public/app/menus/link_context_menu.js

@@ -2,21 +2,21 @@ import contextMenu from "./context_menu.js";
 import appContext from "../components/app_context.js";
 
 function openContextMenu(notePath, hoistedNoteId, e) {
-    contextMenu.show({
+    return contextMenu.show({
         x: e.pageX,
         y: e.pageY,
         items: [
             {title: "Open note in a new tab", command: "openNoteInNewTab", uiIcon: "bx bx-empty"},
             {title: "Open note in a new split", command: "openNoteInNewSplit", uiIcon: "bx bx-dock-right"},
             {title: "Open note in a new window", command: "openNoteInNewWindow", uiIcon: "bx bx-window-open"}
         ],
-        selectMenuItemHandler: ({command}) => {
+        selectMenuItemHandler: async ({command}) => {
             if (!hoistedNoteId) {
                 hoistedNoteId = appContext.tabManager.getActiveContext().hoistedNoteId;
             }
 
             if (command === 'openNoteInNewTab') {
-                appContext.tabManager.openContextWithNote(notePath, { hoistedNoteId });
+                appContext.tabManager.openContextWithNote(notePath, {hoistedNoteId});
             }
             else if (command === 'openNoteInNewSplit') {
                 const subContexts = appContext.tabManager.getActiveContext().getSubContexts();
@@ -28,7 +28,7 @@ function openContextMenu(notePath, hoistedNoteId, e) {
                 appContext.triggerCommand('openInWindow', {notePath, hoistedNoteId});
             }
         }
-    });
+    })
 }
 
 export default {

src/public/app/widgets/note_map.js

@@ -57,7 +57,7 @@ export default class NoteMapWidget extends NoteContextAwareWidget {
 
         window.addEventListener('resize', () => this.setDimensions(), false);
 
-        this.$widget.find(".map-type-switcher button").on("click",  async e => {
+        this.$widget.find(".map-type-switcher button").on("click", async e => {
             const type = $(e.target).closest("button").attr("data-type");
 
             await attributeService.setLabel(this.noteId, 'mapType', type);
@@ -91,6 +91,8 @@ export default class NoteMapWidget extends NoteContextAwareWidget {
 
         await libraryLoader.requireLibrary(libraryLoader.FORCE_GRAPH);
 
+        let isContextMenuOpening = false
+
         this.graph = ForceGraph()(this.$container[0])
             .width(this.$container.width())
             .height(this.$container.height())
@@ -112,8 +114,17 @@ export default class NoteMapWidget extends NoteContextAwareWidget {
             .linkDirectionalArrowRelPos(1)
             .linkWidth(1)
             .linkColor(() => this.css.mutedTextColor)
-            .onNodeClick(node => appContext.tabManager.getActiveContext().setNote(node.id))
-            .onNodeRightClick((node, e) => linkContextMenuService.openContextMenu(node.id, null, e));
+            .onNodeClick(node => {
+                if (!isContextMenuOpening) {
+                    appContext.tabManager.getActiveContext().setNote(node.id)
+                }
+            })
+            .onNodeRightClick(async (node, e) => {
+                isContextMenuOpening = true;
+
+                const contextMenu = await linkContextMenuService.openContextMenu(node.id, null, e);
+                const removeHideHandler = contextMenu.onHide(() => {isContextMenuOpening = false; removeHideHandler()});
+            });
 
         if (this.mapType === 'link') {
             this.graph