Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting up github workflow to test notebooks #11

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Setting up github workflow to test notebooks #11

merged 3 commits into from
Mar 14, 2024

Conversation

hwpang
Copy link
Collaborator

@hwpang hwpang commented Mar 12, 2024

No description provided.

@hwpang hwpang requested a review from mjohnson541 March 12, 2024 17:42
mjohnson541
mjohnson541 reviewed Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@mjohnson541 mjohnson541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, that's a nice pytest trick to automatically run notebooks. Can you squash?

@hwpang
Copy link
Collaborator Author

hwpang commented Mar 14, 2024

@mjohnson541 Done, could you merge once tests pass? Thanks!

@hwpang hwpang changed the title Try setting up github workflow Setting up github workflow to test notebooks Mar 14, 2024
@mjohnson541 mjohnson541 merged commit 695212a into main Mar 14, 2024
1 check passed
@mjohnson541 mjohnson541 deleted the add_tests branch March 14, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjohnson541 mjohnson541 mjohnson541 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwpang @mjohnson541