Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcf/header: Add generic records accessors #68

Closed
zaeleus opened this issue Jan 5, 2022 · 0 comments · Fixed by #69
Closed

vcf/header: Add generic records accessors #68

zaeleus opened this issue Jan 5, 2022 · 0 comments · Fixed by #69
Labels
enhancement New feature or request vcf

Comments

@zaeleus
Copy link
Owner

zaeleus commented Jan 5, 2022

2. The header is still lacking mutable access to the unstructured fields. Perhaps it would make sense to add either get_mut/delete to go with get/insert, and/or simply add records/records_mut for full access?

#66

Add

  • vcf::Header::records -> &IndexMap<String, Vec<Record>> and
  • vcf::Header::records_mut -> &mut IndexMap<String, Vec<Record>>

to access the header map field. This is a map of generic records.
@zaeleus zaeleus added the vcf label Jan 5, 2022
@zaeleus zaeleus mentioned this issue Jan 5, 2022
Merged
@malthesr malthesr mentioned this issue Jan 5, 2022
Merged
@zaeleus zaeleus added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request vcf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vcf/header: Add getter and mutable getter for unstructured records
1 participant
@zaeleus