Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not export FormikWizard as default export. #8

Closed
michelts opened this issue Aug 13, 2019 · 3 comments · Fixed by #9
Closed

Do not export FormikWizard as default export. #8

michelts opened this issue Aug 13, 2019 · 3 comments · Fixed by #9

Comments

@michelts
Copy link
Collaborator

michelts commented Aug 13, 2019

Hi @zaguiini

Jared palmer's tsdx don't handle default exports very well.

To be able to use FormikWizard, I need to use the prop default from the default imported module:

import FormikWizard from 'formik-wizard';
...
<FormikWizard.default ... />

What do you think about using only named exports?

@zaguiini
Copy link
Owner

To be honest, I prefer default exports... And I'm not sure why but the example works with the default. But this looks to be a recurrent issue, so yes I'm open to that. Let's keep exporting the default, but lets name export FormikWizard as well. I'll create the PR.

@zaguiini
Copy link
Owner

Thanks for the heads up!

@michelts
Copy link
Collaborator Author

Hi @zaguiini

Great! I think this is the best approach for the moment.

Thanks for the quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants