Read rank of deployment from environment_type #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation from bitbucket is actually not that good, because it doesn't explain any of the fields in question. However I observed on the bitbucket-cloud instance that the previous implementation lead to errors during imports of deployment configurations into a terraform state. Steps to reproduce the error: 1. Create a repository in bitbucket-cloud 2. Create a deployment for the repository via GUI for Production or Staging (not Test!) 3. write a terraform module (which exactly matches the deployment) and perform `terraform import` to import the existing deployment into the terraform state 4. perform `terraform apply` and terraform wants to change the resource! This change reads the rank from the `environment_type` which is the only valid source if the deployment was created via UI and still a valid source for a deployment which was created via this provider. Reference: https://developer.atlassian.com/cloud/bitbucket/rest/api-group-deployments/#api-repositories-workspace-repo-slug-environments-environment-uuid-get-response Closes: zahiar#186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation from bitbucket is actually not that good, because it doesn't explain any of the fields in question. However I observed on the bitbucket-cloud instance that the previous implementation lead to errors during imports of deployment configurations into a terraform state.
Steps to reproduce the error:
terraform importto import the existing deployment into the terraform stateterraform applyand terraform wants to change the resource!This change reads the rank from the
environment_typewhich is the only valid source if the deployment was created via UI and still a valid source for a deployment which was created via this provider.Reference: https://developer.atlassian.com/cloud/bitbucket/rest/api-group-deployments/#api-repositories-workspace-repo-slug-environments-environment-uuid-get-response
Closes: #186