Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mypy happy (explicit reexport) #154

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

a1d4r
Copy link
Contributor

@a1d4r a1d4r commented Jun 11, 2024

What is the current behavior?

Mypy in strict mode is not happy about the library:

error: Module "decimify" does not explicitly export attribute "decimify"  [attr-defined]
    from decimify import decimify

The error is caused by rule --no-implicit-reexport. There are two ways how to fix it: either define __all__ in __init__.py or use import aliases so that other modules can import it. In this PR I added an alias for an import in __init__.py.

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72265e4) to head (9f09cf0).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           55        55           
=========================================
  Hits            55        55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zahidkizmaz zahidkizmaz merged commit fa2e2bd into zahidkizmaz:main Jun 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants