Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pluralize #82

Merged
merged 9 commits into from
Aug 21, 2020
Merged

Conversation

rolandmueller
Copy link
Contributor

Add a new module for a PLURALIZE tag
For a noun or a list of nouns, it will match any singular or plural word.
Usage for a single word, e.g.:

PLURALIZE("car")

Usage for lists, e.g.:

vehicles = {"car", "bicycle", "ship"}
PLURALIZE(vehicles)

Will work even for regex or if the lemmatizer of spaCy is making an error.
Has dependency to the Python inflect package https://pypi.org/project/inflect/

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #82 into master will decrease coverage by 0.57%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   93.36%   92.79%   -0.58%     
==========================================
  Files          12       13       +1     
  Lines         648      666      +18     
  Branches      112      115       +3     
==========================================
+ Hits          605      618      +13     
- Misses         30       34       +4     
- Partials       13       14       +1     
Impacted Files Coverage Δ
rita/modules/pluralize.py 72.22% <72.22%> (ø)
rita/parser.py 89.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cfb52...9f0bd63. Read the comment docs.

@zaibacu
Copy link
Owner

zaibacu commented Aug 21, 2020

Okay, thank you! For this and previous pull request I will add documentation, tests, changelog entries etc. and hopefully can release it today ;)

@zaibacu zaibacu merged commit 3b0c65e into zaibacu:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants