Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/regex tag #81

Merged
merged 6 commits into from Aug 21, 2020
Merged

Conversation

rolandmueller
Copy link
Contributor

This feature would introduce the TAG element as a module. Needs a new parser for the SpaCy translate.
Would allow more flexible matching of detailed part-of-speech tag, like all adjectives or nouns: TAG("^NN|^JJ").

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #81 into master will increase coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   92.56%   92.61%   +0.04%     
==========================================
  Files          11       12       +1     
  Lines         619      636      +17     
  Branches      106      108       +2     
==========================================
+ Hits          573      589      +16     
- Misses         31       32       +1     
  Partials       15       15              
Impacted Files Coverage Δ
rita/macros.py 96.96% <ø> (ø)
rita/engine/translate_spacy.py 84.74% <60.00%> (+1.41%) ⬆️
rita/engine/translate_standalone.py 86.81% <100.00%> (-0.97%) ⬇️
rita/modules/tag.py 100.00% <100.00%> (ø)
rita/config.py 91.04% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bbd4d6...3d33bc3. Read the comment docs.

@zaibacu
Copy link
Owner

zaibacu commented Aug 21, 2020

Looks nice! just need one test to keep coverage and some minor lint stuff (doing flake8 locally, exclude parsetab: --exclude=rita/parsetab.py because it's generated file and fails most of the rules)

@zaibacu zaibacu merged commit 279999c into zaibacu:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants