Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

85 custom regex impl #86

Merged
merged 5 commits into from
Aug 27, 2020
Merged

85 custom regex impl #86

merged 5 commits into from
Aug 27, 2020

Conversation

zaibacu
Copy link
Owner

@zaibacu zaibacu commented Aug 27, 2020

Closes #85

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #86 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   92.79%   92.80%   +0.01%     
==========================================
  Files          13       13              
  Lines         666      667       +1     
  Branches      115      115              
==========================================
+ Hits          618      619       +1     
  Misses         34       34              
  Partials       14       14              
Impacted Files Coverage Δ
rita/engine/translate_spacy.py 84.74% <100.00%> (ø)
rita/engine/translate_standalone.py 90.21% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0c65e...30a8165. Read the comment docs.

@zaibacu zaibacu merged commit 91d7718 into master Aug 27, 2020
@zaibacu zaibacu deleted the 85-custom-regex-impl branch August 27, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom regex impl for standalone engine
1 participant