-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganized to DMIParse and DMIDecode objects #5
Conversation
Fixed redundant spaces in type2str dictionary Added useful queries for precise information retrieval
…midecode command locally, Added model query, Fixed several corner cases, Fixed linter errors (flake8),
60492a3
to
44909b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Code wise we're good to go.
I only added some comments on the readme.
Also if you could format your code using black, and make sure all the github actions are green.
Thanks
Christophe, I'm kind of lost regarding black. What is wrong with my formatting? I'm following PEP-8 style using flake8. Where can I find mentioned non-green github actions? |
Nothing is wrong with it by itself. I just choose to use black to format all the code so I can just ensure that the same styling is used everywhere. You can read about it at: https://github.com/psf/black Regarding the github actions, not sure why, but they don't seem to be triggered in your PR. Maybe because I added them after you opened your PR. |
The content of your PR is correct. So don't bother with black I can always just format the code once after I merge. |
Actually I do not use any Github actions at all (if you are referring to this. |
@luboss all merged ! Thanks for your contribution :-) |
Thank you too @zaibon for merging my changes to master and your support. I'm happy to see the new major release (0.1.0) of py-dmidecode at pypi.org :-) |
Code reorganization and new features