Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized to DMIParse and DMIDecode objects #5

Merged
merged 4 commits into from
Oct 10, 2019
Merged

Conversation

luboss
Copy link
Contributor

@luboss luboss commented Oct 4, 2019

Code reorganization and new features

lubos.katrinec@gmail.com added 2 commits October 3, 2019 15:03
Fixed redundant spaces in type2str dictionary
Added useful queries for precise information retrieval
…midecode command locally,

Added model query,
Fixed several corner cases,
Fixed linter errors (flake8),
@zaibon zaibon force-pushed the master branch 6 times, most recently from 60492a3 to 44909b7 Compare October 6, 2019 19:24
Copy link
Owner

@zaibon zaibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code wise we're good to go.
I only added some comments on the readme.

Also if you could format your code using black, and make sure all the github actions are green.

Thanks

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@zaibon zaibon mentioned this pull request Oct 6, 2019
@luboss
Copy link
Contributor Author

luboss commented Oct 8, 2019

Christophe, I'm kind of lost regarding black. What is wrong with my formatting? I'm following PEP-8 style using flake8. Where can I find mentioned non-green github actions?

@zaibon
Copy link
Owner

zaibon commented Oct 8, 2019

Nothing is wrong with it by itself. I just choose to use black to format all the code so I can just ensure that the same styling is used everywhere. You can read about it at: https://github.com/psf/black

Regarding the github actions, not sure why, but they don't seem to be triggered in your PR. Maybe because I added them after you opened your PR.

@zaibon
Copy link
Owner

zaibon commented Oct 8, 2019

The content of your PR is correct. So don't bother with black I can always just format the code once after I merge.
Just make sure the conflict is resolved and I will merge it.

@luboss
Copy link
Contributor Author

luboss commented Oct 9, 2019

Actually I do not use any Github actions at all (if you are referring to this.
Regarding black, I wanted to install python-black as instructed in the Atom plugin (editor I use) but pip could not find it (tried both 3.6 and 2.7).
I resolved the conflict by putting my version of dmidecode.py. If you want to change/add anything, you can do it after pull to master.

@zaibon zaibon merged commit 194d61d into zaibon:master Oct 10, 2019
@zaibon
Copy link
Owner

zaibon commented Oct 10, 2019

@luboss all merged ! Thanks for your contribution :-)

@luboss
Copy link
Contributor Author

luboss commented Oct 11, 2019

Thank you too @zaibon for merging my changes to master and your support. I'm happy to see the new major release (0.1.0) of py-dmidecode at pypi.org :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants