Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map generation: military crash site didn't have compatible ammo for weapons #33

Closed
zaimoni opened this issue Mar 30, 2020 · 1 comment
Closed

map generation: military crash site didn't have compatible ammo for weapons #33

zaimoni opened this issue Mar 30, 2020 · 1 comment
Labels
bug Something isn't working post-commit review This needs review for user-visible gameplay effects that warrant backing out.
Projects
0.2.2

Comments

@zaimoni
Copy link
Owner

zaimoni commented Mar 30, 2020

Inherited from C:Whales. This is exceedingly unrealistic (ok to have empty firearms, not ok to be issued ammo that corresponds to no firearms issued)
@zaimoni zaimoni added bug Something isn't working post-commit review This needs review for user-visible gameplay effects that warrant backing out. labels Mar 30, 2020
@zaimoni zaimoni added this to Vaporware in 0.3.0 via automation Mar 30, 2020
@zaimoni zaimoni moved this from Vaporware to Blocker in 0.3.0 Mar 30, 2020
@zaimoni
Copy link
Owner Author

zaimoni commented Apr 16, 2020

Not so conservative fix landed as 0c6af90 . Intent is to only guarantee that if a map special has at least one item using ammunition or fuel, that any C++ ammo objects generated will be usable by at least one such item. If no ammo items are generated at all, or no ammo using items are generated: no effect.

@zaimoni zaimoni closed this as completed Apr 16, 2020
0.3.0 automation moved this from Blocker to Resolved Apr 16, 2020
@zaimoni zaimoni removed this from Resolved in 0.3.0 Apr 29, 2020
@zaimoni zaimoni added this to Vaporware in 0.2.2 via automation Apr 29, 2020
@zaimoni zaimoni moved this from Vaporware to Resolved in 0.2.2 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working post-commit review This needs review for user-visible gameplay effects that warrant backing out.
Projects
No open projects
0.2.2
  
Resolved
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaimoni