feature: views | queues & stats #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
2can
commented
Apr 13, 2017
•
2can
commented
zaiste
requested changes
Apr 14, 2017
lib/web/routes/home.js
Outdated
| let busy = await Job.activeSize(); | ||
| let sizes = await Queue.sizes(await Queue.all()); | ||
| let queued = Object.keys(sizes).reduce((acc, queue) => { | ||
| return acc += sizes[queue]; |
lib/web/routes/home.js
Outdated
| async function dashboard(ctx, next) { | ||
| await ctx.render('index', {}); | ||
| let done = await Job.processedSize(); |
lib/web/routes/home.js
Outdated
| let done = await Job.processedSize(); | ||
| let failed = await Job.failedSize(); | ||
| let busy = await Job.activeSize(); | ||
| let sizes = await Queue.sizes(await Queue.all()); |
There was a problem hiding this comment.
@2can let's make sizes to return by default the size for all queues, no additional call
lib/queue.js
Outdated
| @@ -38,15 +38,23 @@ class Queue extends EventEmitter { | |||
| return `blezer:queues:${this.name}` | |||
| } | |||
|
|
|||
| get jobs() { | |||
| static jobs() { | |||
There was a problem hiding this comment.
@2can this cannot be static, cf this below
lib/queue.js
Outdated
| return redis.lrangeAsync(this.path, 0, -1); | ||
| } | ||
|
|
||
| get size() { | ||
| return redis.llenAsync(this.path); | ||
| static size(name = 'default') { |
There was a problem hiding this comment.
@2can it'd be more coherent to not use it as static
zaiste
reviewed
Apr 14, 2017
lib/queue.js
Outdated
| static get all() { | ||
| static async sizes(names = ['default']) { | ||
| let sizes = {}; | ||
| for (const name of names) { |
There was a problem hiding this comment.
@2can this is an antipattern http://eslint.org/docs/rules/no-await-in-loop
2can
force-pushed
the
feature-views
branch
2 times, most recently
from
8189723
to
bd225b4
Compare
2can
changed the title
|
@zaiste done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.