Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lasso.finished performance for large geojson feature set #24

Closed
erodrig9 opened this issue Jul 15, 2020 · 8 comments
Closed

lasso.finished performance for large geojson feature set #24

erodrig9 opened this issue Jul 15, 2020 · 8 comments

Comments

@erodrig9
Copy link

I am working on a prototype to select from zip/postal code features. Currently I am only loading the data for one state. After the lasso selection is done, even for a small selection, there is about a 10s lag until the lasso.finished event is fired.

Attached example.
example.zip

@zakjan
Copy link
Owner

zakjan commented Jul 27, 2020

Hi @erodrig9, until I can investigate possible improvements, is it feasible for you to turn off intersect mode? Default contain mode is significantly faster in your example. ~1s instead of a few secs.

@erodrig9
Copy link
Author

Hi @zakjan, the preferred behavior would be intersection but I will check if we can get by with contain for now. Thanks for looking into this.

@niharsalunke
Copy link

niharsalunke commented Jul 27, 2020

As a part of an NGO project, I have used your lasso feature in my project. you may find the implementation at https://bloomindia.in/search-donor . I hope your efforts will help someone. 😄❤ The project is still in beta phase and depends on a Google API which gets exhausted during testing.

@zakjan
Copy link
Owner

zakjan commented Jul 29, 2020

@niharsalunke Glad it helped you! I was recently accepted for GitHub Sponsors https://github.com/sponsors/zakjan so if anyone benefits from my open-source activities, now there is a way to sponsor them.

@zakjan
Copy link
Owner

zakjan commented Jul 30, 2020

@erodrig9 I have published 2.1.2, which contains two performance improvements for your case, see the changelog. It got better when doing a small selection. Could you try it?

The slowness is still noticeable when doing a large selection around all the polygons. For further improvements, I should probably use a specialized index data structure.

@erodrig9
Copy link
Author

@zakjan Thanks! I will try it out.

@erodrig9
Copy link
Author

@zakjan This is working significantly faster. Appreciate the effort.

@zakjan
Copy link
Owner

zakjan commented Aug 18, 2020

Thanks! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants