Fix extract-turnin permissions #53
Open
+31
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerout
force-pushed
the
fix-extract-perms
branch
12 times, most recently
from
9d1b1c9
to
9f206d8
Compare
|
Hi @zakkak, do you have any idea why this test fails? I tried many things, but it seems I am missing something. |
zakkak
reviewed
Nov 7, 2022
.github/workflows/main.yml
Outdated
| pull_request: | ||
| paths: | ||
| - 'src/**' | ||
| - 'Makefile' | ||
| - '.github/workflows/main.yml' | ||
|
|
||
| - 'scripts/**' |
There was a problem hiding this comment.
Suggested change
| - 'scripts/**' | |
| - 'scripts/**' | |
Let's keep the newline here :)
Nope, you will need to figure out which command is the one that fails and then see why. Maybe using |
innerout
force-pushed
the
fix-extract-perms
branch
from
9f206d8
to
d2b0487
Compare
innerout
force-pushed
the
fix-extract-perms
branch
from
d2b0487
to
039a37e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR grants only read-write permissions to the owner that calls
extract-turninand no permissions for group,others.umask 077before file extraction begins.Closes Weak Permission Set for turnin_extract #23