Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to tag context to translations so duplicate keys can still have different meanings #6

Merged
merged 1 commit into from Sep 23, 2018

Conversation

zakkudo
Copy link
Owner

@zakkudo zakkudo commented Sep 23, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 23, 2018

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         419    467   +48     
  Branches       76     79    +3     
=====================================
+ Hits          419    467   +48
Impacted Files Coverage Δ
src/isLocalizationFunctionStart.js 100% <ø> (ø) ⬆️
src/hasTranslation.js 100% <100%> (ø) ⬆️
src/readString.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️
src/parseLocalizationFunction.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd8955...aeaf1c1. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 23, 2018

Pull Request Test Coverage Report for Build 226

  • 131 of 131 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 193: 0.0%
Covered Lines: 467
Relevant Lines: 467

💛 - Coveralls

@zakkudo zakkudo force-pushed the addContext branch 7 times, most recently from 8adf4b2 to f9297d9 Compare September 23, 2018 21:31
@zakkudo zakkudo merged commit 779aa4d into master Sep 23, 2018
@zakkudo zakkudo deleted the addContext branch September 23, 2018 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants