cary500 #247
Merged
cary500 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lpatiny
commented
Oct 15, 2022
lpatiny
commented
- wip: prepare cary500Loader
- update!: support for fileCollection and guess the spectra type (update!: support for fileCollection and guess the spectra type #246)
- feat: add experimental cary500Loader
- chore: update dependencies and add testcase
- chore: add missing vitest import
* update: support for fileCollection and classification of spectra * update: a few missing types, and prettify * test: disable temporarely getIVMeasurement * chore: rename files to fileCollection * chore: add todo to use FiltCollection.filter Co-authored-by: Luc Patiny <luc@patiny.com>
✅ Deploy Preview for analysis-ui-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 88.39% // Head: 89.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 88.39% 89.59% +1.20%
==========================================
Files 8 9 +1
Lines 491 567 +76
Branches 79 93 +14
==========================================
+ Hits 434 508 +74
- Misses 57 59 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.