Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Extend logging interface #268

Closed
Retro64 opened this issue Sep 27, 2021 · 1 comment · Fixed by #269
Closed

Improvement: Extend logging interface #268

Retro64 opened this issue Sep 27, 2021 · 1 comment · Fixed by #269

Comments

@Retro64
Copy link
Collaborator

Retro64 commented Sep 27, 2021

Authmosphere was initially designed to fit arbitrary logger-interfaces matching the interface of log4js.

Extend the logging-interface to support other logging interfaces like the interface of pino.

@Retro64
Copy link
Collaborator Author

Retro64 commented Oct 25, 2021

It looks like the types are also not compatible with the native log4js types - which would be compatible to the pino types, changing
from

type LogFunction = (message: string, error?: any) => void;

to

type LogFunction = (message: string, ...args: any[]) => void;

should fix the problem and should also be fully downwards compatible and not breaking.

Retro64 added a commit that referenced this issue Oct 25, 2021
Retro64 added a commit that referenced this issue Oct 25, 2021
Retro64 added a commit that referenced this issue Oct 25, 2021
* fix(type): Fix logger type and update dependencies

close #268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant