This repository has been archived by the owner on May 26, 2020. It is now read-only.
Further updates to tweak UX: #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbbco Thanks for your contribution with this great PR! |
- Don't show unnessecary logs in console
- Tweak handling of filter to provide better feedback upon JQ filter execution and errors by appropriately changing the border of the filter textbox
- Better UI under Load Filters modal
- Add confirmation dialog when deleting filters
- Make [x] into an actual button that only displays when hovering over the filter
- Other CSS tweaks
Signed-off-by: Brian Goad <bdgoad@gmail.com>
|
Yep, sorry, I forgot about the DCO. Signed. |
mrandi
reviewed
Jun 24, 2019
| @@ -30,6 +30,10 @@ export default class InputOutput extends Component<InputOutputProps, InputOutput | |||
| const { hideUnfilteredJson } = this.state; | |||
| const prettyInput = prettyJson(inputJson); | |||
| const prettyOutput = prettyJson(outputJson); | |||
| // Remove extension specific options before passing to Brace | |||
|
@bbbco that's great! thx! |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a slew of updates I made to the extension to address some UX issues I've experienced after using it more extensively this past month or two: