skip annotating non existing resources #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linki
reviewed
Jan 18, 2023
provisioner/clusterpy.go
Outdated
| @@ -1170,6 +1170,10 @@ func overrideDeletionProtection(ctx context.Context, kind, name string, iface dy | |||
| return err | |||
| } | |||
| _, err = iface.Patch(ctx, name, k8stypes.JSONPatchType, payload, metav1.PatchOptions{}) | |||
| if err != nil && apierrors.IsNotFound(err) { | |||
| logger.Infof("Skipping deletion of %s %s: resource not found", kind, name) | |||
There was a problem hiding this comment.
This line will be logged twice I believe.
Signed-off-by: Mahmoud Gaballah <mahmoud.gaballah@zalando.de>
myaser
force-pushed
the
annotate-resources-for-deletion
branch
from
8da6339
to
d132a46
Compare
|
👍 |
1 similar comment
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mahmoud Gaballah mahmoud.gaballah@zalando.de