provisioner: update split template function logic for empty input #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanZavodskikh
approved these changes
Mar 29, 2023
| "foo,bar") | ||
|
|
||
| require.NoError(t, err) | ||
| require.Equal(t, "0=foo1=bar", result) |
There was a problem hiding this comment.
minor: "0=foo1=bar" this format seems very strange to me. However, I think it already works here, so see no problem merging it.
There was a problem hiding this comment.
This is not a format really but a test template to show what are the values it ranges over
|
👍 |
Splitting empty string intuitively should produce zero parts.
Stdlib strings.Split returns s if s does not contain d therefore
strings.Split("", ",") returns one part [""].
This should simplify a common pattern:
```
{{ if ne .ConfigItems.foo "" }}
{{ range $bar := split .ConfigItems.foo "," }}
- "{{ $bar }}"
{{ end }}
{{ end }}
```
to
```
{{ range $bar := split .ConfigItems.foo "," }}
- "{{ $bar }}"
{{ end }}
```
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
provisioner/split-empty
branch
from
beff6c4
to
0637538
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting empty string intuitively should produce zero parts.
Stdlib strings.Split returns s if s does not contain d therefore strings.Split("", ",") returns one part [""].
This should simplify a common pattern:
to