build: mute unused-parameter revive linter error #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
| @@ -60,8 +60,8 @@ func listAction(resource string) func(k8stesting.Action) bool { | |||
|
|
|||
| func deleteAction(resource, name string) func(k8stesting.Action) bool { | |||
| return func(action k8stesting.Action) bool { | |||
| delete, ok := action.(k8stesting.DeleteAction) | |||
| return ok && delete.GetResource().Resource == resource && delete.GetName() == name | |||
| deleteAction, ok := action.(k8stesting.DeleteAction) | |||
There was a problem hiding this comment.
redefines-builtin-id: redefinition of the built-in function delete (revive)
.golangci.yml
Outdated
| @@ -17,3 +19,6 @@ issues: | |||
| - linters: | |||
| - staticcheck | |||
| text: "SA9003:" | |||
| - linters: | |||
| - revive | |||
| text: "unused-parameter: parameter '.+' seems to be unused, consider removing or renaming it as _" | |||
There was a problem hiding this comment.
Alternatively we can fix these
make lint 2>/dev/null | grep unused-parameter | wc -l
33
There was a problem hiding this comment.
For context these are the kind of issues flagged:
pkg/decrypter/decrypter_test.go:10:32: unused-parameter: parameter 'secret' seems to be unused, consider removing or renaming it as _ (revive)
func (d mockDecrypter) Decrypt(secret string) (string, error) {
^
pkg/decrypter/decrypter_test.go:16:35: unused-parameter: parameter 'secret' seems to be unused, consider removing or renaming it as _ (revive)
func (d mockErrDecrypter) Decrypt(secret string) (string, error) {
^
channel/directory.go:27:28: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (d *Directory) Update(ctx context.Context, logger *log.Entry) error {
^
channel/directory.go:31:29: unused-parameter: parameter 'channel' seems to be unused, consider removing or renaming it as _ (revive)
func (d *Directory) Version(channel string, overrides map[string]string) (ConfigVersion, error) {
^
channel/directory.go:39:25: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (d *Directory) Get(ctx context.Context, logger *log.Entry) (Config, error) {
^
channel/mock_source.go:23:29: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (s *mockSource) Update(ctx context.Context, logger *logrus.Entry) error {
^
channel/mock_source.go:27:46: unused-parameter: parameter 'overrides' seems to be unused, consider removing or renaming it as _ (revive)
func (s *mockSource) Version(channel string, overrides map[string]string) (ConfigVersion, error) {
^
channel/git.go:117:39: unused-parameter: parameter 'overrides' seems to be unused, consider removing or renaming it as _ (revive)
func (g *Git) Version(channel string, overrides map[string]string) (ConfigVersion, error) {
^
pkg/kubernetes/kubernetes_test.go:63:3: redefines-builtin-id: redefinition of the built-in function delete (revive)
delete, ok := action.(k8stesting.DeleteAction)
^
pkg/kubernetes/kubernetes_test.go:72:34: unused-parameter: parameter 'resource' seems to be unused, consider removing or renaming it as _ (revive)
func (f *fakeRESTMapper) KindFor(resource schema.GroupVersionResource) (schema.GroupVersionKind, error) {
^
pkg/kubernetes/kubernetes_test.go:76:35: unused-parameter: parameter 'resource' seems to be unused, consider removing or renaming it as _ (revive)
func (f *fakeRESTMapper) KindsFor(resource schema.GroupVersionResource) ([]schema.GroupVersionKind, error) {
^
pkg/kubernetes/kubernetes_test.go:88:39: unused-parameter: parameter 'input' seems to be unused, consider removing or renaming it as _ (revive)
func (f *fakeRESTMapper) ResourcesFor(input schema.GroupVersionResource) ([]schema.GroupVersionResource, error) {
^
pkg/kubernetes/kubernetes_test.go:92:38: unused-parameter: parameter 'gk' seems to be unused, consider removing or renaming it as _ (revive)
func (f *fakeRESTMapper) RESTMapping(gk schema.GroupKind, versions ...string) (*meta.RESTMapping, error) {
^
pkg/kubernetes/kubernetes_test.go:96:39: unused-parameter: parameter 'gk' seems to be unused, consider removing or renaming it as _ (revive)
func (f *fakeRESTMapper) RESTMappings(gk schema.GroupKind, versions ...string) ([]*meta.RESTMapping, error) {
^
pkg/kubernetes/kubernetes_test.go:100:47: unused-parameter: parameter 'resource' seems to be unused, consider removing or renaming it as _ (revive)
func (f *fakeRESTMapper) ResourceSingularizer(resource string) (singular string, err error) {
^
registry/static.go:12:39: unused-parameter: parameter 'filter' seems to be unused, consider removing or renaming it as _ (revive)
func (r *staticRegistry) ListClusters(filter Filter) ([]*api.Cluster, error) {
^
registry/static.go:29:40: unused-parameter: parameter 'cluster' seems to be unused, consider removing or renaming it as _ (revive)
func (r *staticRegistry) UpdateCluster(cluster *api.Cluster) error {
^
registry/file.go:30:37: unused-parameter: parameter 'filter' seems to be unused, consider removing or renaming it as _ (revive)
func (r *fileRegistry) ListClusters(filter Filter) ([]*api.Cluster, error) {
^
pkg/updatestrategy/rolling_update_test.go:43:55: unused-parameter: parameter 'nodePool' seems to be unused, consider removing or renaming it as _ (revive)
func (m *mockNodePoolManager) MarkPoolForDecommission(nodePool *api.NodePool) error {
^
pkg/updatestrategy/clc_update_test.go:36:58: unused-parameter: parameter 'nodePool' seems to be unused, consider removing or renaming it as _ (revive)
func (m *mockNodePoolManagerCLC) MarkPoolForDecommission(nodePool *api.NodePool) error {
^
pkg/updatestrategy/node_pool_manager_test.go:44:44: unused-parameter: parameter 'nodePool' seems to be unused, consider removing or renaming it as _ (revive)
func (n *mockProviderNodePoolsBackend) Get(nodePool *api.NodePool) (*NodePool, error) {
^
pkg/updatestrategy/node_pool_manager_test.go:52:62: unused-parameter: parameter 'decrementDesired' seems to be unused, consider removing or renaming it as _ (revive)
func (n *mockProviderNodePoolsBackend) Terminate(node *Node, decrementDesired bool) error {
^
pkg/updatestrategy/aws_asg_test.go:27:53: unused-parameter: parameter 'input' seems to be unused, consider removing or renaming it as _ (revive)
func (a *mockASGAPI) DescribeAutoScalingGroupsPages(input *autoscaling.DescribeAutoScalingGroupsInput, fn func(*autoscaling.DescribeAutoScalingGroupsOutput, bool) bool) error {
^
pkg/updatestrategy/aws_asg_test.go:32:48: unused-parameter: parameter 'input' seems to be unused, consider removing or renaming it as _ (revive)
func (a *mockASGAPI) DescribeAutoScalingGroups(input *autoscaling.DescribeAutoScalingGroupsInput) (*autoscaling.DescribeAutoScalingGroupsOutput, error) {
^
controller/controller_test.go:43:39: unused-parameter: parameter 'cluster' seems to be unused, consider removing or renaming it as _ (revive)
func (p *mockErrProvisioner) Supports(cluster *api.Cluster) bool {
^
controller/controller_test.go:57:45: unused-parameter: parameter 'cluster' seems to be unused, consider removing or renaming it as _ (revive)
func (p *mockErrCreateProvisioner) Supports(cluster *api.Cluster) bool {
^
controller/controller_test.go:85:37: unused-parameter: parameter 'filter' seems to be unused, consider removing or renaming it as _ (revive)
func (r *mockRegistry) ListClusters(filter registry.Filter) ([]*api.Cluster, error) {
^
controller/controller_test.go:120:36: unused-parameter: parameter 'logger' seems to be unused, consider removing or renaming it as _ (revive)
func (r *mockChannelSource) Delete(logger *log.Entry, config channel.Config) error {
^
controller/controller_test.go:143:36: unused-parameter: parameter 'manifestName' seems to be unused, consider removing or renaming it as _ (revive)
func (c *mockConfig) StackManifest(manifestName string) (channel.Manifest, error) {
^
controller/controller_test.go:147:35: unused-parameter: parameter 'manifestName' seems to be unused, consider removing or renaming it as _ (revive)
func (c *mockConfig) EtcdManifest(manifestName string) (channel.Manifest, error) {
^
controller/controller_test.go:151:39: unused-parameter: parameter 'profileName' seems to be unused, consider removing or renaming it as _ (revive)
func (c *mockConfig) NodePoolManifest(profileName string, manifestName string) (channel.Manifest, error) {
^
provisioner/clusterpy_test.go:281:36: unused-parameter: parameter 'manifestName' seems to be unused, consider removing or renaming it as _ (revive)
func (c *mockConfig) StackManifest(manifestName string) (channel.Manifest, error) {
^
provisioner/clusterpy_test.go:289:39: unused-parameter: parameter 'profileName' seems to be unused, consider removing or renaming it as _ (revive)
func (c *mockConfig) NodePoolManifest(profileName string, manifestName string) (channel.Manifest, error) {
^
provisioner/template_test.go:15:13: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
func render(t *testing.T, templates map[string]string, templateName string, data interface{}, adapter *awsAdapter) (string, error) {
I would propose we fix them
There was a problem hiding this comment.
Looks like there are many more once you start fixing them so I guess it is fine to exclude this rule
There was a problem hiding this comment.
Renamed in the second commit so we can choose the way
Comment on lines
1
to
+3
| run: | ||
| timeout: 10m | ||
|
|
There was a problem hiding this comment.
Dangling run: did not look like a valid yaml so I decided to move timeout config from Makefile
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
build/fix-revive-linter
branch
from
bdd28aa
to
81da17f
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#0