provisioner: add dict template function #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
provisioner/dict-template-func
branch
from
1ae334c
to
8119774
Compare
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Nov 29, 2023
requires dict function zalando-incubator/cluster-lifecycle-manager#711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
|
Here is the prospective usecase zalando-incubator/kubernetes-on-aws#6592 |
AlexanderYastrebov
force-pushed
the
provisioner/dict-template-func
branch
2 times, most recently
from
71a01d9
to
ab3d9f0
Compare
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Nov 29, 2023
requires dict function zalando-incubator/cluster-lifecycle-manager#711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Nov 29, 2023
requires dict function zalando-incubator/cluster-lifecycle-manager#711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Nov 29, 2023
requires dict function zalando-incubator/cluster-lifecycle-manager#711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Nov 29, 2023
requires dict function zalando-incubator/cluster-lifecycle-manager#711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Nov 29, 2023
requires dict function zalando-incubator/cluster-lifecycle-manager#711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Nov 29, 2023
requires dict function zalando-incubator/cluster-lifecycle-manager#711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
|
Needs #712 to fix the build |
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Nov 29, 2023
requires dict function zalando-incubator/cluster-lifecycle-manager#711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Nov 29, 2023
requires dict function zalando-incubator/cluster-lifecycle-manager#711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Add dict template function inspired by https://stackoverflow.com/questions/18276173/calling-a-template-with-several-pipeline-parameters/18276968#18276968 Compared to stackoverflow version it additionally checks for duplicate keys. Also decided not to use `dict` from github.com/Masterminds/sprig/v3 as it allows non-string keys, uneven number of arguments and does not check for duplicate keys. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
provisioner/dict-template-func
branch
from
ab3d9f0
to
8a9d95e
Compare
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Jun 3, 2024
This is useful for defining a fixed list instead of splitting a comma-separated string. See also previous #711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jun 3, 2024
This is useful for defining a fixed list instead of splitting a comma-separated string. See also previous #711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jun 3, 2024
This is useful for defining a fixed list instead of splitting a comma-separated string. See also previous #711 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dict template function inspired by
https://stackoverflow.com/questions/18276173/calling-a-template-with-several-pipeline-parameters/18276968#18276968
Compared to stackoverflow version it additionally checks for duplicate keys.
Also decided not to use
dictfrom github.com/Masterminds/sprig/v3 as it allows non-string keys, uneven number of arguments and does not check for duplicate keys.