Skip to content

Commit

Permalink
Skip ingress loadbalancer update
Browse files Browse the repository at this point in the history
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
  • Loading branch information
AlexanderYastrebov committed May 9, 2022
1 parent 60a1a28 commit 1d38d0e
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion worker.go
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,9 @@ func updateIngress(kubeAdapter *kubernetes.Adapter, lb *loadBalancer, problems *
}
for _, ingresses := range lb.ingresses {
for _, ing := range ingresses {
if skipUpdateIngressLoadBalancer(ing) {
continue
}
if err := kubeAdapter.UpdateIngressLoadBalancer(ing, dnsName); err != nil {
if err == kubernetes.ErrUpdateNotNeeded {
log.Debugf("Update not needed for %s with DNS name %s", ing, dnsName)
Expand Down Expand Up @@ -625,7 +628,7 @@ func updateDNS(dnsUpdater kubernetes.DNSUpdater, model []*loadBalancer, problems

for _, ingresses := range lb.ingresses {
for _, ingress := range ingresses {
if ingress.ResourceType != kubernetes.TypeFabricGateway {
if skipUpdateHostnames(ingress) {
continue
}
for _, hostname := range ingress.Hostnames {
Expand All @@ -646,6 +649,14 @@ func updateDNS(dnsUpdater kubernetes.DNSUpdater, model []*loadBalancer, problems
}
}

func skipUpdateIngressLoadBalancer(ingress *kubernetes.Ingress) bool {
return ingress.ResourceType == kubernetes.TypeFabricGateway
}

func skipUpdateHostnames(ingress *kubernetes.Ingress) bool {
return !skipUpdateIngressLoadBalancer(ingress)
}

func deleteStack(awsAdapter *aws.Adapter, lb *loadBalancer, problems *problem.List) {
stackName := lb.stack.Name
if err := awsAdapter.DeleteStack(lb.stack); err != nil {
Expand Down

0 comments on commit 1d38d0e

Please sign in to comment.