worker: check cloudformation stack status #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
check-stack-errors
branch
2 times, most recently
from
257d218
to
a145d3f
Compare
Stack update may fail due to external changes, e.g. due to removal of a referenced security group. This change reports certain stack statuses as problems which prevents `last_sync_timestamp_seconds` metric update that could be used to monitor stack update failures. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
check-stack-errors
branch
from
a145d3f
to
cdc2506
Compare
| return nil | ||
| } | ||
|
|
||
| switch s.status { |
There was a problem hiding this comment.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack update may fail due to external changes, e.g. due to removal of
a referenced security group.
This change reports certain stack statuses as problems which prevents
last_sync_timestamp_secondsmetric update that could beused to monitor stack update failures.
Signed-off-by: Alexander Yastrebov alexander.yastrebov@zalando.de