worker: run doWork at fixed rate
#506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently controller waits for `pollingInterval` after each `doWork` run that takes `W` time long. Work rate and metrics counter change rate is therefore equal to `1 / (pollingInterval + W)` which makes it hard to configure alerts based on the counter change rate thresholds due to unknown `W`. This change runs controller work cycle at fixed rate of `1 / pollingInterval`. For the existing deployments the side effect would be reduced work cycle and increased API request rates, e.g. for `W` of 15s and default `pollingInterval` of 30s the work cycle is reduced from 45s to 30s (-33%). Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
|
Also if |
|
👍 |
It is better to configure absolute rate thresholds that would not depend on the controller work cycle duration at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently controller waits for
pollingIntervalafter eachdoWorkrun that takesWtime long.Work rate and metrics counter change rate is therefore equal to
1 / (pollingInterval + W)which makes it hard to configure alerts based on the counter change rate thresholds due to unknown
W.This change runs controller work cycle at fixed rate of
1 / pollingInterval.For the existing deployments the side effect would be reduced work cycle and increased API request rates,
e.g. for
Wof 15s and defaultpollingIntervalof 30s the work cycle is reduced from 45s to 30s (-33%).Signed-off-by: Alexander Yastrebov alexander.yastrebov@zalando.de