Add test case for stack in RollbackInProgress state #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
|
You test the current state as far as I understand. If there is an error we will get into ROLLBACK state, but do you get from that test?
How does your PR achieve this? I think what we want is to test for example a known wrong state (from our current alerting for example wrong WAF association) and then how we can come out of this state without delete/recreate (causes downtime), but maybe:
The order is important and delete needs to be postponed until some time in the future as we normally do. |
szuecs
changed the title
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a CloudFormation stack is in
ROLLBACK_IN_PROGRESSit returns no output, hence no target groups. While CloudFormation is working to get the stack back the controller may send traffic to LBs without TG.This PR is trying to replicate this behaviour, current state means that we also collect stacks in this state which we shouldn't do.