CDP Build Steps #69
Merged
CDP Build Steps #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
njuettner
commented
Jun 16, 2017
•
njuettner
commented
- CDP Steps for Kube-Ingress-Controller on AWS
mikkeloscar
reviewed
Jun 16, 2017
delivery.yaml
Outdated
| IS_PR_BUILD=${CDP_PULL_REQUEST_NUMBER+"true"} | ||
| if [[ ${CDP_TARGET_BRANCH} == "master" && ${IS_PR_BUILD} != "true" ]] | ||
| then | ||
| make build.docker build.push |
There was a problem hiding this comment.
make build.push is enough
|
👍 |
mikkeloscar
reviewed
Jun 16, 2017
delivery.yaml
Outdated
| export GOPATH=$HOME/go | ||
| export OPERATOR_TOP_DIR=$GOPATH/src/github.com/zalando-incubator | ||
| mkdir -p $OPERATOR_TOP_DIR | ||
| ln -s $(pwd) $OPERATOR_TOP_DIR/kube-ingress-aws-controller |
There was a problem hiding this comment.
nit: maybe also change the OPERATOR_TOP_DIR to another name, it's maybe a bit confusing why it's called this way.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.