Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kubernetes 1.11 #1198

Merged
merged 54 commits into from
Sep 11, 2018
Merged

Update to Kubernetes 1.11 #1198

merged 54 commits into from
Sep 11, 2018

Conversation

linki
Copy link
Member

@linki linki commented Jun 26, 2018

Let's see what the e2es have to say about this.

Changes:

  • Update Hyperkube to 1.11.x
  • Update CoreOS to the latest stable (as of July 4)
  • Remove PodPriority feature flag as it's enabled by default
  • Switch from KubeProxy's iptables mode to ipvs mode
  • Disable docker version change, therefore it uses 18.03.x with the AMI above which is not officially supported by Kubernetes 1.11 (let's see where we end up; 1.12 and 17.03.x work fine and are supported)
  • Remove PersistentVolumeClaimResize feature flag (enabled by default)
  • Remove CustomResourceSubresources feature gate (enabled by default).

- "On"
- "Off"
- "Auto"
- "Off"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file change is just for testing. Don't merge me.

@hjacobs
Copy link
Contributor

hjacobs commented Jul 3, 2018

@linki what is the impact of switching to ipvs? We should have a good understanding of how it works and what the benefits/drawbacks are.

@linki
Copy link
Member Author

linki commented Jul 4, 2018

@hjacobs It claims to be more performant and seems to become the default option going forward. From the release notes: "This change delivers better network throughput, better programming latency, and higher scalability limits for the cluster-wide distributed load-balancer that comprises the Kubernetes Service model"

However, there's a known-issue in Kubernetes 1.11 so I think we should wait for the next release.

I was just curious if e2e would pass: it does.

@szuecs
Copy link
Member

szuecs commented Jul 10, 2018

@linki maybe we want not to switch to ipvs kubernetes/kubernetes#57841.
I was suggesting this to do but maybe we should rethink and review what bugs exists on ipvs and which in iptables.

@linki
Copy link
Member Author

linki commented Jul 10, 2018

@szuecs yes, it's mentioned as a known issue in the release notes as well. We should wait.

@mikkeloscar
Copy link
Contributor

Yes, this sounds like quite a serious problem :)

Signed-off-by: Mikkel Oscar Lyderik Larsen <m@moscar.net>

# Conflicts:
#	cluster/manifests/kube-proxy/daemonset.yaml
#	cluster/node-pools/master-default/userdata.clc.yaml
#	cluster/node-pools/worker-default/userdata.clc.yaml
mode: 0644
contents:
inline: yes
{{end}}
Copy link
Member Author

@linki linki Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix the docker version again. I would like to try out docker 17 as 18 isn't officially supported.

Furthermore the new (better) way of defining versions for those bundled binaries is using torcx: https://coreos.com/blog/toward-docker-17-in-container-linux

hjacobs and others added 21 commits August 21, 2018 17:39
Remove the `--allow-privileged` flag from the kubelet since it now
defaults to `true` and has been marked deprecated and will be removed in
v1.13.

kubernetes/kubernetes#63442

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
Remove deprecated --allow-privileged kubelet flag
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
@aermakov-zalando
Copy link
Contributor

👍

@mikkeloscar
Copy link
Contributor

👍

@mikkeloscar mikkeloscar merged commit 3914a79 into dev Sep 11, 2018
@szuecs szuecs mentioned this pull request Sep 12, 2018
@mikkeloscar mikkeloscar mentioned this pull request Sep 17, 2018
@aermakov-zalando aermakov-zalando deleted the kube-1.11 branch January 3, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants