Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes v1.12.6 + Use Docker images for individual components instead of hyperkube #1825

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

aermakov-zalando
Copy link
Contributor

@aermakov-zalando aermakov-zalando commented Feb 13, 2019

This includes two changes:

@mikkeloscar
Copy link
Contributor

Apparently nobody uses hyperkube

Could you add a reference for this statement? :) I mean I don't really care, but if I look at this PR in 6 months it will not be clear why we changed away from hyperkube.

@hjacobs
Copy link
Contributor

hjacobs commented Feb 14, 2019

Please also reference the issues we had with Hyperkube (if any).

aermakov-zalando and others added 2 commits February 28, 2019 14:48
Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
@mikkeloscar mikkeloscar changed the title Use Docker images for individual components instead of hyperkube Kubernetes v1.12.6 + Use Docker images for individual components instead of hyperkube Feb 28, 2019
@mikkeloscar
Copy link
Contributor

👍

@mikkeloscar
Copy link
Contributor

Reference to why we go away from hyperkube is in the PR comment

@szuecs
Copy link
Member

szuecs commented Mar 4, 2019

@mikkeloscar
Copy link
Contributor

@szuecs kube-component is the generic name for the binary inside the docker image that we build. (you can see our internal build pipeline here: https://github.bus.zalan.do/teapot/kubernetes-pipeline/blob/9d3803c93cf47a903b447f2aaddf356160546432/Dockerfile#L7)

@szuecs
Copy link
Member

szuecs commented Mar 4, 2019

ok thanks

@szuecs
Copy link
Member

szuecs commented Mar 4, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants