Add support for inline ConfigMaps in StackSet CRD #7179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linki
added
do-not-merge
minor
3 tasks
|
👍 |
linki
force-pushed
the
inline-configmaps
branch
from
84f3a81
to
9e975c1
Compare
|
👍 |
1 similar comment
|
👍 |
This was referenced Mar 18, 2024
Merged
Merged
Merged
Merged
Comment on lines
+360
to
+373
| {{- if eq .Cluster.ConfigItems.stackset_inline_configmap_support_enabled "true" }} | ||
| configMap: | ||
| description: ConfigMap to be owned by Stack | ||
| properties: | ||
| data: | ||
| additionalProperties: | ||
| type: string | ||
| description: Data of the ConfigMap | ||
| type: object | ||
| name: | ||
| description: Name of the ConfigMap | ||
| type: string | ||
| type: object | ||
| {{ end }} |
There was a problem hiding this comment.
Looks like these were not added to the origin stack CRD https://github.com/zalando-incubator/stackset-controller/blob/master/docs/stack_crd.yaml
There was a problem hiding this comment.
Noticed while working on #7297
There was a problem hiding this comment.
Thanks. Yes, this wasn't merged 🤦 I created a separate PR to fix it: zalando-incubator/stackset-controller#621
There was a problem hiding this comment.
We merged it to master now. It's slightly different than here (code comments) but the structure is the same. Let's update it in one of the subsequent PRs that modify the spec.
There was a problem hiding this comment.
Thank you, I will update that within #7297
AlexanderYastrebov
added a commit
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Note also that #7179 added configMap fields that are not part of origin CRDs yet. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Note also that #7179 added configMap fields that are not part of origin CRDs yet. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
that referenced
this pull request
Apr 11, 2024
Update to require unique hosts for ingress and routegroup and include other pending updates. See * zalando-incubator/stackset-controller#580 * zalando-incubator/stackset-controller#583 * zalando-incubator/stackset-controller#612 * zalando-incubator/stackset-controller#613 Note also that #7179 added configMap fields that are not part of origin CRDs yet. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update StackSet CRD for inline ConfigMaps. This is just an early version to update CRD in stackset-controller's e2e cluster to be able to run the test cases.