fix: types for outgoing http headers #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NodeJS typescript definitions has OutgoingHttpHeaders with
undefinedas one of the possible values, but NodeJS runtime will throw an error for undefined values in headers.We overwrite the headers type in the RequestOptions and removes undefined from one of the possible values of headers.
Upstream discussion/changes: DefinitelyTyped/DefinitelyTyped#36265
Why did it have
undefinedin the first place? - likely a workaround for some cases - DefinitelyTyped/DefinitelyTyped#20695 (comment)