Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other ingress controller #113

Closed
arjunrn opened this issue Mar 20, 2019 · 3 comments · Fixed by #180
Closed

Add support for other ingress controller #113

arjunrn opened this issue Mar 20, 2019 · 3 comments · Fixed by #180

Comments

@arjunrn
Copy link
Contributor

arjunrn commented Mar 20, 2019

Current the controller is tied to Skipper as an ingress controller and the dependency is for the traffic switching annotation. The controller should support other ingress providers as well such like Traefik which works exactly the same as skipper with the annotation traefik.ingress.kubernetes.io/service-weights. Nginx behaves a little differently because it doesn't define the multiple backends on the same ingress but allows multiple ingresses with the same host.

@szuecs
Copy link
Member

szuecs commented Mar 20, 2019

Traefik already agreed on using ours, see https://twitter.com/timoreimann/status/1107792769421111296

@szuecs szuecs closed this as completed Mar 20, 2019
@szuecs szuecs reopened this Mar 21, 2019
@szuecs
Copy link
Member

szuecs commented Dec 16, 2019

I think with https://github.com/zalando-incubator/stackset-controller/releases/tag/v1.1.0 we enable anyone to create whatever resource to build the LB infrastructure.

@szuecs szuecs closed this as completed Dec 16, 2019
@szuecs
Copy link
Member

szuecs commented Dec 16, 2019

I thought about it again and realized, that we could pass the annotation name via flag, default to zalando.org/backend-weights, which should fix the issue much better.

@szuecs szuecs reopened this Dec 16, 2019
szuecs added a commit that referenced this issue Dec 16, 2019
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
szuecs added a commit that referenced this issue Jan 6, 2020
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants