Pass-on annotations to Ingress objects

[linki]

apiVersion: zalando.org/v1
kind: StackSet
metadata:
  name: cluster-registry
spec:
  ingress:
    annotations:
      zalando.org/skipper-filter: ...

Custom annotations specified by users should be passed-on to the generated Ingress object.

[mikkeloscar]

It's a bug if this is not the case. It should happen:

stackset-controller/controller/ingress.go

Lines 386 to 389 in 30e2ddc

	// insert annotations
	for k, v := range stackset.Spec.Ingress.Annotations {
	ingress.Annotations[k] = v
	}

[mikkeloscar]

Or annotations should be under metadata:

apiVersion: zalando.org/v1
kind: StackSet
metadata:
  name: cluster-registry
spec:
  ingress:
    metadata:
      annotations:
        zalando.org/skipper-filter: ...

Since we don't have validation yet (#10) the error is not caught in your example :(

Maybe we want to remove the need for defining the metadata key, but it was done this way to make the API more Kubernetes'ish.

[linki]

That's fine for me. It works when putting it under metadata.