refactor(renderer): Extract the renderer to a new library #30
Conversation
affects: tessellate-fragment, tessellate-renderer
|
Looks good so far. I'd like to add a commit to clean up the dependencies a bit and to fix the failing tests. |
|
Please go ahead :) |
affects: tessellate-renderer
affects: tessellate-renderer
affects: tessellate-renderer
affects: tessellate-renderer
affects: tessellate-renderer Tessellate libraries should be named with simple verbs or nouns but not with verbs used as nouns. Tessellate services should be named with any nouns.
affects: tessellate-fragment
affects: tessellate-render
affects: tessellate-fragment, tessellate-render
affects: tessellate-fragment
affects: tessellate-render
affects: tessellate-render
|
Changes Unknown when pulling c822205 on extract-tesselate-renderer into ** on master**. |
| @@ -1 +1,2 @@ | |||
| /dist | |||
| test/__snapshots__ | |||
There was a problem hiding this comment.
Jest snapshots must be included in the repository. Otherwise running the test is always going to create a new snapshot from scratch and not validate against the existing one. See also http://facebook.github.io/jest/docs/tutorial-react-native.html#snapshot-test.
| @@ -37,7 +37,8 @@ | |||
| "react": "15.3.2", | |||
| "react-dom": "15.3.2", | |||
| "request": "2.78.0", | |||
| "request-promise-native": "1.0.3" | |||
| "request-promise-native": "1.0.3", | |||
| "tessellate-renderer": "../tessellate-renderer" | |||
There was a problem hiding this comment.
We should declare this dependency absolutely and let Lerna handle the resolution: https://github.com/lerna/lerna#how-bootstrap-works.
| warn: debug(`${PREFIX}:warn:${name}`), | ||
| error: debug(`${PREFIX}:error:${name}`) | ||
| } | ||
| } |
There was a problem hiding this comment.
I suggest completely removing logger.js (and logging) from this library for now and later re-add it via #31
|
👍 |
|
Changes Unknown when pulling 9be9941 on extract-tesselate-renderer into ** on master**. |
affects: tessellate-fragment, tessellate-renderer