This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
feat(fragment): Added support for dynamic content #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: tessellate-fragment Content is fetched before the fragment is rendered. Content is added to react props. 34
|
Changes Unknown when pulling aed5f53 on 34-dynamic-content-loading into ** on master**. |
mfellner
reviewed
Jan 20, 2017
| // @flow | ||
|
|
||
| import url from 'url' | ||
| import createRequest from './content-request-factory' |
There was a problem hiding this comment.
It's not very idiomatic to put simple functions like createRequest into their own modules. I'd suggest inlining createRequest into content-service.
affects: tessellate-fragment Moved content request factory to content-service. 45
|
Changes Unknown when pulling 127430d on 34-dynamic-content-loading into ** on master**. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: tessellate-fragment
Content is fetched before the fragment is rendered. Content is added to react props.
34