This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Improve tessellate-server #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 31, 2017 17:49
affects: tessellate-server
affects: tessellate-server
affects: tessellate-server
affects: tessellate-server
affects: tessellate-server
…files. affects: tessellate-server Part of #39.
affects: tessellate-server
affects: tessellate-server
affects: tessellate-server
|
Changes Unknown when pulling e99fb6e on 37-improve-server into ** on master**. |
semonte
reviewed
Feb 1, 2017
|
|
||
| this.app | ||
| .use(morgan(morganFormat, {skip: morganSkip})) | ||
| .use(error) | ||
| .use(error()) | ||
| .use(bodyParser({enableTypes: ['json'], strict: true})) |
There was a problem hiding this comment.
strict already has a default value of true, we should keep configuration at minimum.
danpersa
reviewed
Feb 1, 2017
|
|
||
| const [appServer, metricsServer] = await Promise.all([ | ||
| startServer(this.app.callback(), port), | ||
| startServer(this.metrics.callback(), metricsPort) | ||
| startServer(this.app.callback(), parseInt(port)), |
There was a problem hiding this comment.
you should extract parseInt(port) as a constant
danpersa
approved these changes
Feb 1, 2017
affects: tessellate-server
mfellner
force-pushed
the
37-improve-server
branch
from
9a2f5fc
to
21c7948
Compare
|
Changes Unknown when pulling 21c7948 on 37-improve-server into ** on master**. |
|
Changes Unknown when pulling 21c7948 on 37-improve-server into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve tessellate-server in preparation for #37.