This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
perf(fragment): parallelized content and bundle HTTP requests #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfellner
suggested changes
Mar 13, 2017
| const bundleIndex = 0; | ||
| const contentIndex = 1; | ||
| const { bundle, props } = promises[bundleIndex]; | ||
| const content = promises[contentIndex]; |
There was a problem hiding this comment.
You can use destructuring here to make the content more concise:
const [bundle, content] = await Promise.all([...])
// or
const [{ bundle, props }, content] = await Promise.all([...])There was a problem hiding this comment.
Yep, much cleaner that way. I updated the code.
affects: tessellate-fragment Fetch bundle and content in parallel, they have no dependencies to each other. ISSUES CLOSED: #69
semonte
force-pushed
the
parallel-loading
branch
from
34ebc0c
to
89ba62e
Compare
mfellner
approved these changes
Mar 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: tessellate-fragment
Fetch bundle and content in parallel, they have no dependencies to each other.
ISSUES CLOSED: #69