Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Add contribution notice #95

Merged
merged 2 commits into from Sep 28, 2017
Merged

Add contribution notice #95

merged 2 commits into from Sep 28, 2017

Conversation

mfellner
Copy link
Contributor

Closes #94.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.756% when pulling 2d5faa7 on 94-add-contrib-notice into 2329b09 on master.

@mfellner
Copy link
Contributor Author

👍

Adeynack
Adeynack reviewed Sep 25, 2017
View reviewed changes
README.md Outdated
For details on pull requests, commit messages and contributing please see [CONTRIBUTING.md](CONTRIBUTING.md)

Unless you explicitly state otherwise in advance, any non trivial contribution intentionally submitted for inclusion in this project by you to the steward of this repository (Zalando SE, Berlin) shall be under the terms and conditions of the [MIT License](LICENSE), without any additional copyright information, terms or conditions.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want that paragraph in BOTH files (CONTRIBUTIN.md and README.md)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the recommendations from another Zalando OS repository. Technically we don't need the notice here as well, CONTRIBUTING.md should be enough.

@mfellner
Copy link
Contributor Author

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.756% when pulling 071a7e5 on 94-add-contrib-notice into 2329b09 on master.

@danpersa
Copy link
Contributor

👍

@mfellner mfellner merged commit f3cc299 into master Sep 28, 2017
@mfellner mfellner deleted the 94-add-contrib-notice branch September 28, 2017 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Adeynack Adeynack Adeynack left review comments

@danpersa danpersa danpersa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mfellner @coveralls @danpersa @Adeynack