Make sure new cluster's max compaction lag is 14 days #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the global project for customer data deletion, log compaction has a new maximum lag of 14 days, after which compaction happens. This change has already been applied dynamically to our production and test cluster, but in the case a new cluster gets deployed in the future, in order to avoid a "regression" from sneaking in, we better build bubuku with this property by default, that way our current solution becomes future proof.
|
👍 |
1 similar comment
|
👍 |
|
@ferbncode is it right to say that this PR was done to the wrong repo? right now this gets overriden by https://github.bus.zalan.do/aruha/bubuku-appliance/blob/master/server.properties if I'm not mistaken. I'm checking what's needed in order to deliver https://jira.zalando.net/browse/ARUHA-2614 so I might have to resolve some conflicts on files that are present on both repos but have diverged for some reason. We would be deploying straight from the open source repo, if I got the idea right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the global project for customer data deletion, log
compaction has a new maximum lag of 14 days, after which compaction
happens.
This change has already been applied dynamically to our production and
test cluster, but in the case a new cluster gets deployed in the
future, in order to avoid a "regression" from sneaking in, we better
build bubuku with this property by default, that way our current
solution becomes future proof.