Fix calculation of timeout before next change run #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Changes is not a list, but a mapping from name to list of `Change` objects. 2. Change with a long timeout should not postpone run of scheduled checks. 3. A newly added change has to be executed without delay caused by other changes.
a1exsh
commented
Jul 9, 2021
| @@ -192,5 +203,6 @@ def _add_change_to_queue(self, change): | |||
| def stop(self, change: Change): | |||
| _LOG.info('Stopping controller with additional change: {}'.format(change.get_name() if change else None)) | |||
| # clear all pending changes | |||
There was a problem hiding this comment.
Was this a TODO comment? I don't see that we clear anything here.
There was a problem hiding this comment.
I think it should be removed
antban
approved these changes
Jul 9, 2021
| time_till_next_run = change.time_till_next_run() | ||
| if min_time_till_next_change_run is None: | ||
| min_time_till_next_change_run = time_till_next_run | ||
| else: |
There was a problem hiding this comment.
Suggested change
| else: | |
| elif time_till_next_run is not None: |
There was a problem hiding this comment.
but it's nitpicking feel free to merge as it is.
There was a problem hiding this comment.
What is semantics of None? The method is not even supposed to return that (not optional).
| @@ -192,5 +203,6 @@ def _add_change_to_queue(self, change): | |||
| def stop(self, change: Change): | |||
There was a problem hiding this comment.
Suggested change
| def stop(self, change: Change): | |
| def stop(self, change: Optional[Change]): |
| @@ -192,5 +203,6 @@ def _add_change_to_queue(self, change): | |||
| def stop(self, change: Change): | |||
| _LOG.info('Stopping controller with additional change: {}'.format(change.get_name() if change else None)) | |||
| # clear all pending changes | |||
There was a problem hiding this comment.
I think it should be removed
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changeobjects.Internal ticket: 789
Review