Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#83 Have performance tests #119

Merged
merged 8 commits into from May 6, 2019
Merged

#83 Have performance tests #119

merged 8 commits into from May 6, 2019

Conversation

fbrns
Copy link
Member

@fbrns fbrns commented Mar 14, 2019

#83 Have performance tests

@fbrns fbrns changed the title #83 Have performance tests WIP: #83 Have performance tests Mar 14, 2019
@fbrns fbrns marked this pull request as ready for review March 15, 2019 13:40
@fbrns fbrns requested a review from BGehrels as a code owner March 15, 2019 13:40
@fbrns fbrns changed the title WIP: #83 Have performance tests #83 Have performance tests Mar 15, 2019
@zalando-nakadi zalando-nakadi deleted a comment Mar 15, 2019
@zalando-nakadi zalando-nakadi deleted a comment Mar 15, 2019
@zalando-nakadi zalando-nakadi deleted a comment Mar 15, 2019
@zalando-nakadi zalando-nakadi deleted a comment Mar 15, 2019
@zalando-nakadi zalando-nakadi deleted a comment Mar 15, 2019
@ePaul
Copy link
Member

ePaul commented Mar 21, 2019

Hi,

thanks for the contribution, and sorry for taking that long to look at it.

Could you add a short README which instructs on how this should be used? (It is not part of the normal Travis CI build, right?)

Then @BGehrels and me can test this based on the README.

BGehrels
BGehrels reviewed Apr 15, 2019
View reviewed changes
nakadi-producer-loadtest/README.md

usage:
```
mvn test -Dtest=LoadTestIT -Dgpg.skip=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, one should probably run docker-compose up before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation was enhanced to clarify this topic.

@ePaul ePaul added enhancement spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+) tests only changes test code, not the actual library labels Apr 15, 2019
@BGehrels
Copy link
Contributor

👍

@BGehrels
Copy link
Contributor

Tested it, looks great.

@BGehrels
Copy link
Contributor

@ePaul What do you think? I would love to get this merged

@ePaul ePaul self-assigned this May 6, 2019
@ePaul
Copy link
Member

ePaul commented May 6, 2019

👍

@ePaul
Copy link
Member

ePaul commented May 6, 2019

Looks fine. I wonder whether we want to run this on Travis for feature branches, just to have a record of how the execution time changed. Though this will also depend on the used hardware.

In any case, that would be a separate PR, not part of this one.

Thanks for the contribution, and sorry for taking that long to merge it.

@ePaul ePaul merged commit 0eea6c0 into zalando-nakadi:master May 6, 2019
@ePaul ePaul mentioned this pull request Aug 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BGehrels BGehrels BGehrels left review comments

@ePaul ePaul ePaul approved these changes

Assignees

@ePaul ePaul

Labels
enhancement spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+) tests only changes test code, not the actual library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbrns @ePaul @BGehrels